Despite the clickbait title, I think this is a nice summary of the arguments either way.
I remain unfazed about the X, and having installed the iOS 11 GM on my aging iPhone 6 see no immediate need to upgrade, but would quite likely go for the 8 (or, even better, an SE with the 8’s guts) if the need arose - but I’m not necessarily looking forward to it seeing as the new batteries are smaller, and battery life is one of my prime concerns these days.